Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[198299] RDI Access change for retrieving data from Kobo #3871

Merged
merged 9 commits into from
May 22, 2024
Merged

[198299] RDI Access change for retrieving data from Kobo #3871

merged 9 commits into from
May 22, 2024

Conversation

patryk-dabrowski
Copy link
Contributor

@patryk-dabrowski patryk-dabrowski commented May 15, 2024 •
edited by azure-boards bot
Loading

@patryk-dabrowski patryk-dabrowski added enhancement New feature or request backend Changes in BE code labels May 15, 2024
@patryk-dabrowski patryk-dabrowski self-assigned this May 15, 2024
@codecov Codecov
Copy link

codecov bot commented May 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.30508% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.86%. Comparing base (b8fbb3c) to head (aa7904d).

Files Patch % Lines
backend/hct_mis_api/apps/core/kobo/api.py 97.56% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           develop    #3871       +/-   ##
============================================
+ Coverage    44.74%   77.86%   +33.11%     
============================================
  Files          396      397        +1     
  Lines        31911    31964       +53     
  Branches      5203     5203               
============================================
+ Hits         14280    24888    +10608     
+ Misses       17292     6156    -11136     
- Partials       339      920      +581
Flag Coverage Δ
e2e 44.93% <32.20%> (+0.18%) ⬆️
unittests 76.84% <98.30%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patryk-dabrowski patryk-dabrowski force-pushed the feature/198299 branch 4 times, most recently from 5f49099 to 839b2bd Compare May 17, 2024 11:15
@patryk-dabrowski patryk-dabrowski changed the base branch from develop to ephemeral-1 May 22, 2024 10:20
@patryk-dabrowski patryk-dabrowski merged commit a5e60d5 into ephemeral-1 May 22, 2024
13 checks passed
@patryk-dabrowski patryk-dabrowski deleted the feature/198299 branch May 22, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johniak johniak johniak approved these changes

Assignees

@patryk-dabrowski patryk-dabrowski

Labels
backend Changes in BE code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patryk-dabrowski @johniak